Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error with version 1.6.30 #810

Open
Elisa8321 opened this issue May 14, 2024 · 21 comments
Open

Fatal error with version 1.6.30 #810

Elisa8321 opened this issue May 14, 2024 · 21 comments
Labels

Comments

@Elisa8321
Copy link

Describe the bug:

After getting a fatal error with version 1.6.29 I updated to 1.6.30 but it triggers a fatal error anyway..and I get this message: An error of type E_COMPILE_ERROR was caused in line 16 of the file /homepages/12/d495428187/htdocs/app497430624/wp-content/plugins/header-footer-elementor/inc/lib/svg-sanitizer/src/Sanitizer.php. Error message: Cannot declare class enshrined\svgSanitize\Sanitizer, because the name is already in use

With version 1.6.29 it was something in line 32 causing a compile error

WordPress version:

6.5.3

Elementor version:

3.21.5

@Elisa8321 Elisa8321 added the bug label May 14, 2024
@themuddfamily
Copy link

+1 also getting this issue

@bellottidesign
Copy link

bellottidesign commented May 14, 2024

The current situation is very unfortunate. I noticed the bug this morning when I wanted to set up a new instance for a customer and received the said error on the 32 line with version 1.6.29.

Fortunately, I was able to fall back to version 1.6.28 on an alternative instance that I had set up yesterday.

Let's hope that the bug can be completely fixed with 1.6.31.

If permitted, I can also upload the .zip for version 1.6.28 here.

@m1ga
Copy link

m1ga commented May 14, 2024

If permitted, I can also upload the .zip for version 1.6.28 here.

you can always download older versions at the normal plugin page: https://wordpress.org/plugins/header-footer-elementor/advanced/ (at the bottom). No need to upload ZIP files here

@PeculiarHead
Copy link

I did the exact same thing. My site was dead, so I rolled back to 1.6.28 and all was well again. So we'll just wait for 1.6.30 and it's not a big deal (as I haven't read the release notes to see what was updated, but 28 currently works fine for me). Cheers.

@m1ga
Copy link

m1ga commented May 14, 2024

#811 will hopefully fix all issues. Perhaps they'll test it this time 😉

@0xK3on
Copy link

0xK3on commented May 14, 2024

I did the exact same thing. My site was dead, so I rolled back to 1.6.28 and all was well again. So we'll just wait for 1.6.30 and it's not a big deal (as I haven't read the release notes to see what was updated, but 28 currently works fine for me). Cheers.

FATAL error is not a big deal? I woke up with a phone call from my client complaining his website is DEAD!!!

@rchacin
Copy link

rchacin commented May 14, 2024

It worked on most of my sites, but I now have this error on one specific site:

Fatal error: Cannot declare class enshrined\svgSanitize\Sanitizer, because the name is already in use in /****/wp-content/plugins/header-footer-elementor/inc/lib/svg-sanitizer/src/Sanitizer.php on line 16

DIRECT DOWNLOAD LINK FOR 1.6.28
https://downloads.wordpress.org/plugin/header-footer-elementor.1.6.28.zip

@vijetaR
Copy link
Contributor

vijetaR commented May 14, 2024

For the fatal error regarding the sanitizer, we are providing a zip file for the fix v1.6.30.
Here is the link to the zip:
header-footer-elementor.zip

Can you please verify if it's working as expected, as we are unable to replicate it on our end.
Could you please provide the versions of your PHP, WordPress, Elementor and any other dependent plugin on the site so that we can investigate further?

@rchacin
Copy link

rchacin commented May 14, 2024

For the fatal error regarding the sanitizer, we are providing a zip file for the fix v1.6.30. Here is the link to the zip: header-footer-elementor.zip

Can you please verify if it's working as expected, as we are unable to replicate it on our end.

Yes..! It's working for me! THX

@m1ga
Copy link

m1ga commented May 14, 2024

@rchacin are you using any other svg plugin like svg-support? As that is using svgSanitize too. Maybe that is something to test @vijetaR

@rchacin
Copy link

rchacin commented May 14, 2024

@rchacin are you using any other svg plugin like svg-support? As that is using svgSanitize too. Maybe that is something to test @vijetaR

That is absolutely right. I'm using WP SVG Images on the particular site that was failing.

I ALSO WENT BACK TO THE v1.6.30 (Without fix), and the site loaded fine after disabling WP SVG Images.

@digimarkup
Copy link

@vijetaR You can just add the svg support plugin to replicate it on your end. The provided file fixed the issue. Can you please make sure this does not happen again in the next update. I just spent hours manually updating over 50 websites.

@tbscode
Copy link

tbscode commented May 15, 2024

Same issue here, sightly different error message:

PHP Fatal error:  Cannot declare class enshrined\svgSanitize\Sanitizer, because the name is already in use in /bitnami/ │
│ 202.61.241.62 - - [15/May/2024:06:32:43 +0000] "GET /wp-login.php HTTP/1.1"

Using the bitnami wp helm chart for deployment.

Auto-update brought our WP site down, only fix was to manually move the plugin out of wp-content/plugins and then re-install the reverted version.

What caused the issue exactly? That was a surprise to find our page down this morning ;)

@Elodie12345
Copy link

Hello,

I have the same problem but since i'm on wordpress.com I cant restore a previous version.
My dashboard on wordpress won't let me access the plugins, or the versions of the plugins (it can't even see the plugins that were installed!!) and I can't even see the theme or do anything about it !
Can someone please help me ?

@Elisa8321
Copy link
Author

Elisa8321 commented May 15, 2024 via email

@danielmarschall
Copy link

Don't you test your plugin at all before you roll out to millions of websites?!

Yesterday, auto-update to 1.6.29 broke our website, because include to vendor/autoload.php failed, because this file is not existing. Commented out and waited for the hotfox 1.6.30 to come.

Today, auto-update to 1.6.30 and page down again, because of a conflict with class Sanitizer.

Luckily, I know how to look at PHP error logs and comment out the code pieces which are faulty. But other wordpress website owners do not have that experience and will have a broken site which they cannot login to anymore.

I am a software developer myself and I know that bugs do happen. But such trivial bugs could have been detected by just testing the thing or by running tools like PHPstan to detect mistakes like including files which are not existing.

I will disable auto-update now.

@themuddfamily
Copy link

Don't you test your plugin at all before you roll out to millions of websites?!

Yesterday, auto-update to 1.6.29 broke our website, because include to vendor/autoload.php failed, because this file is not existing. Commented out and waited for the hotfox 1.6.30 to come.

Today, auto-update to 1.6.30 and page down again, because of a conflict with class Sanitizer.

Luckily, I know how to look at PHP error logs and comment out the code pieces which are faulty. But other wordpress website owners do not have that experience and will have a broken site which they cannot login to anymore.

I am a software developer myself and I know that bugs do happen. But such trivial bugs could have been detected by just testing the thing or by running tools like PHPstan to detect mistakes like including files which are not existing.

I will disable auto-update now.

Im very surprised this happened, if you look at the commits list the automated tests failed on the merge that caused it, thats when they should have caught this... even if they aren't testing manually this should be sending them an email saying testing failed!

@vijetaR
Copy link
Contributor

vijetaR commented May 16, 2024

Hello,

We apologize for the inconvenience that has been caused by the recent issues – "Error messages during plugin activation" and the "Conflict with WP SVG Images plugin". We are pleased to inform you that we have released an update to fix the issues.

Please update the plugin to the latest version 1.6.31 to resolve the issues.

Thank you for your understanding and patience. If you have any further questions or encounter any issues, please let us know.

@juanpahv
Copy link

can anyone confirm if 1.6.31 is already working? I'm about to rollback to 1.6.28

@rchacin
Copy link

rchacin commented May 16, 2024 via email

@vijetaR
Copy link
Contributor

vijetaR commented May 24, 2024

Hello Everyone, The current plugin version is 1.6.34 So, I would suggest you to update the EHFB plugin to the latest version to resolve the issue. Thanks for understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests