Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brave license helper for new rust vendor location #36707

Open
rillian opened this issue Mar 11, 2024 · 0 comments
Open

Update brave license helper for new rust vendor location #36707

rillian opened this issue Mar 11, 2024 · 0 comments

Comments

@rillian
Copy link

rillian commented Mar 11, 2024

Description

In brave/brave-core#21759 we move third_party rust source directories to a separate subtree away from their documenting README.chromium files. This aligns with what chromium's tooling currently expects, but confuses the license aggregation script. This bug is about updating brave_license_header.py to handle the new locations, or some other appropriate change.

The gnrt tool does check for compatible license declarations in Cargo.toml when importing source, and embeds them in the README, but it often isn't smart enough to generate a path for the License File key.

@rillian rillian self-assigned this Mar 11, 2024
@rebron rebron added this to On Deck in General Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: On Deck
General
  
On Deck
Development

No branches or pull requests

2 participants