Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showstopper due to aws_launch_template tags triggering rebuilds #489

Open
nikolay opened this issue Mar 4, 2024 · 3 comments
Open

Showstopper due to aws_launch_template tags triggering rebuilds #489

nikolay opened this issue Mar 4, 2024 · 3 comments
Labels
wontfix This will not be worked on

Comments

@nikolay
Copy link

nikolay commented Mar 4, 2024

I am using the most popular AWS EKS module and just started using yor, but it turned to be a showstopper as it indirectly changes the tags of aws_launch_template, which leads to the rebuilding of the node groups every single time.

What is the recommended solution to avoid tags to resources, which source code you don't control?

Also, how can the tags be removed as I have a lot of instances?

@ChanochShayner
Copy link
Contributor

Hey @nikolay :)
You can use the --skip-resources flag, an example in the readme.

@nikolay
Copy link
Author

nikolay commented Mar 13, 2024

@ChanochShayner Well, honestly, the documentation is pretty light. As I found it, it doesn't really say, for example, that these are names, not fully qualified names with the resource type, that the names are comma-delimited, etc. Also, there are parameters in the CLI. If I want to have one place for the CLI and the GitHub Actions for these ignores, I need to keep both places in sync. Please allow annotations (via comments, for example) to skip tagging or skip modules by source.

Copy link

stale bot commented Apr 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants