Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Our programs sections #17

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Our programs sections #17

wants to merge 5 commits into from

Conversation

OmarRoBra
Copy link
Collaborator

Description

What did you implemented/Why did you implemented this:

  • I made the programs section of the landing page including responsive design

Screenshots

If applicable, include screenshots of the results or screenshots that help to see changes
image

@OmarRoBra
Our programs sections
0ba178c 
I made the programs section of the landing page including responsive desing
@OmarRoBra OmarRoBra requested review from YilKanda and xFerchoVJ and removed request for YilKanda September 15, 2021 21:03
@OmarRoBra OmarRoBra self-assigned this Sep 15, 2021
@cfcortes cfcortes temporarily deployed to bc-landing-2-feature-13-xa2boq September 15, 2021 21:04 Inactive
xFerchoVJ
xFerchoVJ previously approved these changes Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@xFerchoVJ xFerchoVJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cfcortes cfcortes temporarily deployed to bc-landing-2-feature-13-vzefcq October 4, 2021 23:25 Inactive
YilKanda
YilKanda requested changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@YilKanda YilKanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't delete the sample file for the database configuration.

app/views/home/index.html.erb Outdated Show resolved Hide resolved
config/locales/en.yml Outdated Show resolved Hide resolved
@cfcortes cfcortes temporarily deployed to bc-landing-2-feature-13-rffny3 October 6, 2021 23:29 Inactive
@RobertoCarMed
added database example configuration
434159c 
In previous commits this file was deleted so i added again because is important file
@cfcortes cfcortes temporarily deployed to bc-landing-2-feature-13-rffny3 October 7, 2021 00:01 Inactive
@cfcortes cfcortes temporarily deployed to bc-landing-2-feature-13-rffny3 October 7, 2021 00:03 Inactive
@cfcortes cfcortes linked an issue Oct 12, 2021 that may be closed by this pull request
Nuestros programas section #13
Open
1 task
@cfcortes cfcortes temporarily deployed to bc-landing-2-feature-13-mwbtae October 12, 2021 15:45 Inactive
@cfcortes
Copy link
Contributor

@OmarRoBra en la vista Desktop, al crecerlo a lo ancho, el logo y texto de ui/ux no se posicionan de manera correcta
Captura de Pantalla 2021-10-12 a la(s) 10 51 39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertoCarMed RobertoCarMed RobertoCarMed left review comments

@YilKanda YilKanda YilKanda requested changes

@xFerchoVJ xFerchoVJ xFerchoVJ left review comments

Requested changes must be addressed to merge this pull request.

Assignees

@OmarRoBra OmarRoBra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nuestros programas section
5 participants
@OmarRoBra @cfcortes @YilKanda @xFerchoVJ @RobertoCarMed