Feature#6 about section #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add mobile, tablet and desktop version Add neccesary images to work Co-authored-by: AlejandroVI99 <avi200599@gmail.com>
We added new logo and togglers image to the navbar, also we added styles to them. We deleted the old logos and toggler image. Co-authored-by: SampabloC <sampablo-jisc@outlock.com>
I've finished the mobile version of the hero
Change Logo automatically when user open or close the navbar Add styles for every logo when is open or closed Co-authored-by: AlejandroVI99 <avi200599@gmail.com>
I've finished styling the hero in the tablet layout
We separate the JS scripts from the navbar partial, to a new JS file, also we change the img html tag for the helper image_tag from rails in the navbar. Co-authored-by: SampabloC <sampablo-jisc@outlook.com>
I've finished styling the hero in the desktop layout Co-authored-by: OmarRoBra <jrodriguez40@ucol.mx>
I've finished styling the hero in the desktop layout Co-authored-by: OmarRoBra <jrodriguez40@ucol.mx>
…ers/bc-landing-page-2021 into feature#4_Hero_design
Change font type Fix effect when mouse is over Fix tablet trouble when screen rotate Fix responsive logo Co-authored-by: AlejandroVI99 <avi200599@gmail.com>
1 task
Feature#4 hero design
…sign Feature#3 responsive menu design
The Ruby I18n (shorthand for internationalization) gem which is shipped with Ruby on Rails provides an easy-to-use and extensible framework for translating our application to a single custom language other than English or for providing multi-language support in your application. The process of "internationalization" usually means to abstract all strings and other locale specific bits (such as date or currency formats) out of our application.
xFerchoVJ
previously approved these changes
Sep 9, 2021
…lization-i18n Feature #14 Implementing Rails Internationalization (I18n)
I've eliminated the BrightCoders title
We've fixed the behavior of the hero when switching devices Co-authored-by: OmarRoBra <jrodriguez40@ucol.mx>
Feature#11 fix hero
I've added and semicolon in ./app/javascript/stylesheets/application.scss and also use prettier for my styles file in case a semicolon was missing, it's a code formatter
YilKanda
reviewed
Oct 20, 2021
There was a problem hiding this comment.
Check the commits of your PR, I feel that there are some commits that do not belong to your PR, that can generate duplication of commits in the tree (main branch).
Remember, your PR should only show the commits that you have made.
Use the "Rebase" and not the merge in your branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've coded the about section.
I added the sass structure.
I added the assets images.
I imported the different styles in their respective files.
Screenshots