Text highlighting in Moleskine theme is very low contrast (FF/Win)

[eykanal]

Could you try to reproduce this for me? On my computer, when trying to highlight text on Firefox when using the moleskine theme, it looks as follows:

Whereas in all other themes it looks as follows:

I've searched through the css code looking for any ::-moz-selection or ::selection blocks and didn't see any.

So,

1. Can you reproduce this?
2. Is this intentional? If so, how did you do it without those blocks?
3. If not, let me know, I already have a css rule in place on my computer to fix it, I'll just patch it in a send it over.

[brittohalloran]

Yeah I get the same thing in Firefox, but not Chrome. It might be a Firefox default to switch to the dark on light highlighting when there's an image as the background, instead of a straight color. At any rate, I like forcing it to the standard highlighting, or doing something else (like maybe the moleskine orange color?).

[eykanal]

Added pull request (issue #26). I sent it to the dev branch, but I noticed you have an eykanal-dev branch... let me know if you want me to re-issue the pull request to there instead.

[brittohalloran]

Hey this is live now (v0.8.21) but doesn't seem to fix the Firefox issue for me. I still get the old highlighting. Can you check it out? I think the issue is that Firefox doesn't recognize the CSS

[brittohalloran]

Looks like it was removed from the css3 spec. Not sure why
https://developer.mozilla.org/en/CSS/%3A%3Aselection#Specifications

[brittohalloran]

We could just take the grid background off the moleskine theme. It's been suggested before (#13).

[eykanal]

Huh, that's really bizarre, because I'm using that exact same line of CSS in a custom Stylish script, and it works. Checking out the CSS code in Firebug, it's not even being rendered; the line is there in the source file, but it's as if Firefox is simply ignoring it. I wonder why it would be ignored.

Anyways, this prompted me to figure out what the actual problem is, and it turns out to be the note-edit-bg value affecting the .theme-moleskine .window .note .textarea (and others) code block. You currently have note-edit-bg set to a background color of rgb(100,100,100,0.95). I don't know what their algorithm is, but this color (which is pretty dark) makes the highlight color white. If you change that to rgb(255,255,255,0.95), the highlight color goes back to "normal". I didn't see a visible change, so this may be the fix we're looking for.

Alternatively, if you're worried about it affecting the .labels and .versions UI, we can just make it it's own code block. That's probably a better idea.

[brittohalloran]

shoot -- can't duplicate it on firefox on my mac, so i'll have to take your word for it. a couple things though:

• 'note-edit-bg' is the color of the frame around the note after you click on it, so changing it to white is definitely visible. are you maybe talking about another color?
• the .textarea, .labels, and .versions should all be styled the same, so I think it's appropriate to keep them in the same block

[eykanal]

hmm, you're right. I don't know what I was looking at yesterday. Well, either way, just use 175 instead of 255... it's light enough that Firefox doesn't complain, and that color background still goes well with the general UI.

Sorry I wasn't able to send the patch myself, it's been a little nuts around here.

[brittohalloran]

Just pushed the version with the white frame out (v0.8.22).

Also -- I opened up http://dev.notestack.me so I can push "pre-release" versions there in the future

[eykanal]

Thanks. I had been using https://dev.notestack.me/ (https), which had worked, although I had to create a security exception as the cert hadn't been properly signed. That should make things easier.

[brittohalloran]

Awesome. Pushed the light gray version (175) out in v0.8.23
On Dec 23, 2011 8:32 AM, "Eliezer Kanal" <
reply@reply.github.com>
wrote:

Thanks. I had been using https://dev.notestack.me/ (https), which had
worked, although I had to create a security exception as the cert hadn't
been properly signed. That should make things easier.

---

Reply to this email directly or view it on GitHub:
#25 (comment)