Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disco#info gives back a not very descriptive identity #55

Open
abmargb opened this issue May 13, 2014 · 4 comments
Open

disco#info gives back a not very descriptive identity #55

abmargb opened this issue May 13, 2014 · 4 comments

Comments

@abmargb
Copy link
Collaborator

abmargb commented May 13, 2014

I suppose that is not very helpful:

Shouldn't we have something like category='storage' and type='media'?

Suggestions?

@imaginator
Copy link
Member

What does it give now?

But yes - good systems should describe what they do.

As an aside, I just noticed this error reporting...

 curl https://api.stripe.com/v1/charges \
   -d amount=400 \
   -d currency=usd \
   -d card=tok_1041ft2eZvKYlo2CoH7f8O4C \
   -d "description=Charge for test@example.com"

I removed the user and ran...

{
  "error": {
    "type": "invalid_request_error",
    "message": "You did not provide an API key. You need to provide your API key in the Authorization header, using Bearer auth (e.g. 'Authorization: Bearer YOUR_SECRET_KEY'). See https://stripe.com/docs/api#authentication for details, or we can help at https://support.stripe.com/."
  }
}

So yes, at the very least, descriptive components!

@abmargb
Copy link
Collaborator Author

abmargb commented May 13, 2014

Now it gives

<identity category="component" type="generic" name="Media Server" />

I suppose "component" and "generic" does not help much during the discovery process.

@imaginator
Copy link
Member

to me it says couldn't be bothered and should say I'm a freakin' media server now give me your cat pictures

@guilhermesgb
Copy link
Member

Now it's giving an even worse identity:

<identity type="im" name="Tigase ver. 5.2.1-b3461/e362e35b (2014-06-03/10:32:02)" category="server" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants