Resource tracking in OutQueueConsumer seems defunct

[ashward]

The resource tracking code in OutQueueConsumer doesn't seem to work. Nothing seems to be actually tracking resources so the onlineUsers map never seems to get populated with anything. It's causing me a problem with notifications to local admin users.

I guess we could safely get rid of that code now - specifically this bit:

            // Get a list of 'online' resources for this JID
            ArrayList<JID> resources = onlineUsers.getResources(p.getTo());
            logger.debug("There are " + resources.size() + " online resources for " + p.getTo());
            for (JID resource : resources) {
                p.setTo(resource);
                component.sendPacket(p.createCopy());
            }

Happy to make the change myself, but thought I'd check there's no reason for it to still be in there.

[lloydwatkin]

Not sure if I follow @ashward but we're tracking user's presence here: https://github.com/buddycloud/buddycloud-server-java/blob/master/src/main/java/org/buddycloud/channelserver/packetprocessor/presence/PresenceProcessor.java#L40

Admin users are added in configuration as per https://github.com/buddycloud/buddycloud-server-java/blob/master/manual/configuration.md users.admin

[ashward]

Ah, you're right. But it doesn't seem to be working - it's coming up as 0 resources for all the local users as far as I can tell. I'll do a bit more digging when I have a bit more spare time :)

[lloydwatkin]

Are you using database or in-memory store? If database have you applied the most recent updates?