Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding comments refreshes the post view #288

Open
guilhermesgb opened this issue Sep 27, 2013 · 4 comments
Open

Adding comments refreshes the post view #288

guilhermesgb opened this issue Sep 27, 2013 · 4 comments

Comments

@guilhermesgb
Copy link
Member

I was having a good time listening to music on the topic channel https://demo.buddycloud.org/music@topics.buddycloud.org... =)

When I noticed that when I commented something, it would refresh the page, causing the Youtube player to stop playing my music!

It would be a nice thing not to refresh the page in that case.

@imaginator
Copy link
Member

Also noticed this.

Also, if another user posts a comment, while I am writing a comment, I
loose my comment.

On 27 September 2013 04:42, Guilherme Santos notifications@github.comwrote:

I was having a good time listening to music on the topic channel
https://demo.buddycloud.org/music@topics.buddycloud.org... =)

When I noticed that when I commented something, it would refresh the page,
causing the Youtube player to stop playing my music!

It would be a nice thing not to refresh the page in that case.


Reply to this email directly or view it on GitHubhttps://github.com//issues/288
.

Simon Tennant | buddycloud.com | +49 17 8545 0880 | office hours:
goo.gl/tQgxP

@rodrigods
Copy link
Contributor

Seems to be same issue as #256

But, if you have commented in a post, the post will render again and can cause the same effect. What's the best approach to handle incoming comments in this case? The webclient has to bubble the post to the top.

@imaginator
Copy link
Member

Good question... I don't know. Right now though there's two issue.

  • bubbling while editing
  • loosing the content

I'll ask @mrflix this weekend - we're working together both days.

@rodrigods
Copy link
Contributor

Currently, we do not miss the current editing content (comment or post) anymore, but we will lose the embedlyt video streaming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants