Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags with attributes #30

Closed
stereonom opened this issue Nov 25, 2014 · 5 comments
Closed

tags with attributes #30

stereonom opened this issue Nov 25, 2014 · 5 comments
Milestone

Comments

@stereonom
Copy link

I created the following shortcode:

[tab title="I am the titel"]I'm the content[/tab]

The plugins tries to escape the quotation marks like this:

[tab title=\"I am the titel\"]I'm the content[/tab]

But it even renders the backslashes in the wysiwyg-editor and in the text-editor.

My shortcode than fails, because it can't find the title correctly and the fallback title is used.

function add_tab( $atts , $content = null ) {
    // Attributes
    extract( shortcode_atts(
        array(
            'title' => 'Tab',
        ), $atts )
    );
    $markup = '<div class="tabheadline">'.$title.'</div><div class="tabbody">'.apply_filters( 'box_content', $content ).'</div>';
    return $markup;
}
add_shortcode( 'tab', 'add_tab' );
@bueltge
Copy link
Owner

bueltge commented Nov 27, 2014

@stereonom Thanks for the feedback. I gave currently checked on my install and it works. I have add your shortcode tab as custom button in AddQuicktag settings and it is also possible to use inside the editor, see the screenshot. Can you recheck this again.

auswahl_001

But maybe it is a difference between activation on single or multisite. Which WP install do you have?

@bueltge
Copy link
Owner

bueltge commented Nov 27, 2014

@stereonom I think, that I have found a bug and fixed now inside this repository. Can you test the version from here, Download, and give feedback. Thanks.

@bueltge
Copy link
Owner

bueltge commented Dec 18, 2014

@stereonom Please give me a feedback about the topic. Thanks.

@bueltge bueltge added this to the 2.4.0 milestone Dec 18, 2014
@stereonom
Copy link
Author

It works. Thanks!

@bueltge
Copy link
Owner

bueltge commented Dec 18, 2014

Danke für die Rückmeldung!

@bueltge bueltge closed this as completed Dec 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants