Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary of existing issues: #243

Open
bumbeishvili opened this issue Feb 19, 2023 · 7 comments
Open

Summary of existing issues: #243

bumbeishvili opened this issue Feb 19, 2023 · 7 comments

Comments

@bumbeishvili
Copy link
Owner

bumbeishvili commented Feb 19, 2023

  • Performance
    Currently, the node is redrawing every time, expand, collapse , rerender happens, we need to find ways to optimize it
  • Multi Root/Multi Parent
    While multi-parent is not possible, it's possible to connect any node to any node. Multi-root is possible by conditionally hiding the actual root element and only showing children
  • Safari issues
    Generally, if absolute positioning is used, it breaks in safari. Although it's possible to overcome this by manipulating negative margins and making sure elements don't overflow actual node wrapper element
  • Typescript
    I am not maintaining types for this lib, so not responsible for any issues
  • Drag & Drop
    Not planned, but have an idea of how to implement, waiting for someone to finance it
  • Lazy Loading
    Not planned, but have an idea of how to implement
@bumbeishvili bumbeishvili pinned this issue Feb 19, 2023
@bumbeishvili bumbeishvili changed the title Summary of issues: Summary of existing issues: Feb 19, 2023
@n1crack
Copy link

n1crack commented Feb 21, 2023

I need lazy loading and drag & drop features

I can implement drag & drop. But really need lazy loading.

@bumbeishvili
Copy link
Owner Author

I don't plan to add new features (except of what is in the dev branch - 3.0 version) in the near future.

There were some discussions around lazy loading here - #147

It might help you to implement your own

@n1crack
Copy link

n1crack commented Feb 21, 2023

I missed 3.0 version. Gonna look at it.

I wonder how many nodes it can handle ?

@bumbeishvili
Copy link
Owner Author

It's not yet published. Basically, what is added are improved examples and a pagination feature, plan to fix some bugs before I publish it to the main branch, but it's usable to use it right now as it is

@bumbeishvili
Copy link
Owner Author

As for the nodes, if the whole tree is expanded, I was able to display 1800 nodes. If limited nodes are expanded, then it can handle tens of thousands of nodes (because they are not actually drawn)

@n1crack
Copy link

n1crack commented Feb 21, 2023

Ty for the info. btw new example page looks good. I'll add reset view button asap :)

If I can add this button below the node. Then the lazy loading is done :D Probably it wont need any code to the base.

<button
  onclick="chart.addNode({id:'child123',parentId:'100',name:'test',_centered:true}).render()"
>
  Add node to the root
</button>

but it doesn't matter for now. If it can handle 1800 nodes, this is perfect for me. (I think above that count, the user cant handle xD)

@bumbeishvili
Copy link
Owner Author

Yes, but please be aware, it will be very slow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants