Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give client bots a handler for pipe disconnection #873

Open
dgant opened this issue May 19, 2021 · 0 comments
Open

Give client bots a handler for pipe disconnection #873

dgant opened this issue May 19, 2021 · 0 comments

Comments

@dgant
Copy link
Contributor

dgant commented May 19, 2021

Real-time performance requirements in competition disincentivize bots from logging directly to disk. The incentive is instead to flush logs at the end.

However, if a client bot's pipe connection to StarCraft is broken, no further event handlers are called, leaving the bot without a last-ditch chance to flush logs.

Proposed feature: An onTermination() handler which is always called after a game, even in event of disconnection. This handler is called with the expectation that BWAPI is no longer accessible. This would allow bots a chance to flush any logs if they haven't already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants