Potential Issues with OnRenegade

[NiteKat]

Not sure entirely if these are bugs or not for BWAPI, so I wanted to open this issue for these to be investigated, as they involve the hooks into Brood War that generate events, which I'm not super familiar with.

I have observed some oddities with how OnRenegade is called for units when you rescue them from a Rescue Passive player.

1.) If a unit is loaded in a bunker or transport which renegades to you by capturing a Resource Depot, there is no OnRenegade event for the loaded unit. You can still realize it has changed teams by checking if any renegaded unit has loaded units EXCEPT if you just get the unit it's loaded in to renegade on it's own (or at least with bunkers - forget if it works for transports this way). If you get the bunker to renegade on it's own, and not through a resource depot, the units inside do not renegade. The impact to a human player is that the only way to unload them is by unloading all units, you cannot do so individually, and once they are unloaded, they cannot renegade until you get a resource depot from the rescue passive player.

2.) Units that are not in vision do not trigger an OnRenegade event ever. This one is pretty interesting, and I'm thinking this is just how BW works, because usually when you get a rescue passive unit to renegade, there's a little sound and a yellow circle blinks around the unit, but I'm guessing this doesn't happen if the unit is out of sight, so maybe that's why an OnRenegade doesn't trigger? This typically happens when you capture a resource depot, thus you gain all of that player's units, some of which may be out of vision.