You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I should be able to launch Nuclear Strike if I own a Nuclear Silo that contains a Nuclear Missile, even if the Nuclear Missile is owned by a different player. This situation occurs in the BW campaign's second Terran mission, as noticed & discussed by insanityspreadr on Discord and at https://youtu.be/XcYNZQU5T3Y?t=207. It can also occur if I steal another player's Nuclear Silo that already contains a nuke, e.g. they lift off their CC or their CC is destroyed then I land/make my CC next to it.
case TechTypes::Enum::Nuclear_Strike:
if ( thisUnit->getPlayer()->completedUnitCount(UnitTypes::Terran_Nuclear_Missile) == 0 )
return Broodwar->setLastError(Errors::Insufficient_Ammo);
return true;
Instead, presumably, BWAPI should check whether I own a Nuclear Silo that contains a completed Nuclear Missile.
Note: as explained at https://liquipedia.net/starcraft/Nuclear_Silo, if the silo is stolen by a different player, until the silo is destroyed or the nuke is launched, the nuke inside it still takes up supply of the player that made it, and they can't use it even if they have another active Silo. That is why the ownership of the nuclear missile doesn't change players when the ownership of the nuclear silo changes players.
The text was updated successfully, but these errors were encountered:
I should be able to launch Nuclear Strike if I own a Nuclear Silo that contains a Nuclear Missile, even if the Nuclear Missile is owned by a different player. This situation occurs in the BW campaign's second Terran mission, as noticed & discussed by insanityspreadr on Discord and at https://youtu.be/XcYNZQU5T3Y?t=207. It can also occur if I steal another player's Nuclear Silo that already contains a nuke, e.g. they lift off their CC or their CC is destroyed then I land/make my CC next to it.
Currently, BWAPI checks whether I own a Nuclear Missile, at https://github.com/bwapi/bwapi/blob/main/bwapi/Shared/Templates.h#L2221 :
Instead, presumably, BWAPI should check whether I own a Nuclear Silo that contains a completed Nuclear Missile.
Note: as explained at https://liquipedia.net/starcraft/Nuclear_Silo, if the silo is stolen by a different player, until the silo is destroyed or the nuke is launched, the nuke inside it still takes up supply of the player that made it, and they can't use it even if they have another active Silo. That is why the ownership of the nuclear missile doesn't change players when the ownership of the nuclear silo changes players.
The text was updated successfully, but these errors were encountered: