Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm chart version control #11320

Open
daviderli614 opened this issue Mar 25, 2024 · 7 comments
Open

helm chart version control #11320

daviderli614 opened this issue Mar 25, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@daviderli614
Copy link
Contributor

Is your feature request related to a problem?

The bytebase helm chart version is always 1.1.0. When new features are added in the chart, it is still this version. There is no way to helm upgrade?

helm search repo bytebase
NAME             	CHART VERSION	APP VERSION	DESCRIPTION
bytebase/bytebase	1.1.0        	           	Safe database schema change and version control...

Describe the solution you'd like

  1. Suggestion to add appVersion in the chart.yaml.
  2. Add chart version control, every chart version is a new feature.

Additional context

No response

@daviderli614 daviderli614 added the enhancement New feature or request label Mar 25, 2024
@h3n4l
Copy link
Member

h3n4l commented Mar 26, 2024

The bytebase helm chart version is always 1.1.0.

We have other versions before, likes 1.0.0, but we deletes these versions because we deprecated some Bytebase images.

When new features are added in the chart, it is still this version.

Oops, it seems like we forget to bump the Helm version while we add support for resource control via #11094.

Suggestion to add appVersion in the chart.yaml

We will look into this, thanks!

@daviderli614
Copy link
Contributor Author

Thanks for your answer, how to bump the Helm version? Maybe change this Chart.yaml.

We use argocd to dependencies a version of Helm. If the version is deprecated, there may be a dependencies failure?

@h3n4l
Copy link
Member

h3n4l commented Mar 26, 2024

how to bump the Helm version? Maybe change this Chart.yaml.

Yes, but we do not bump the helm (package?) version while we release new version of Bytebase, unless we adjust the chart to support new features or new options. Otherwise, we just upgrade the bytebase version value in the chart.

If the version is deprecated, there may be a dependencies failure?

Maybe. I am not familiar with argocd, but the deprecate operation is very rare and should not be a concern. We delete the old charts because of they reference the deprecated Bytebase images. Otherwise, we would receive numerous artifact hub alert emails which say "Cannot find image."

@h3n4l
Copy link
Member

h3n4l commented Mar 26, 2024

Is it a good practice to bump the helm package version if we modify the default value in values.yaml?

@h3n4l h3n4l self-assigned this Mar 26, 2024
@daviderli614
Copy link
Contributor Author

daviderli614 commented Mar 26, 2024

Is it a good practice to bump the helm package version if we modify the default value in values.yaml?

Maybe every change is a new chart version.

@daviderli614
Copy link
Contributor Author

daviderli614 commented Mar 26, 2024

There are example, like kube-prometheus-stack and grafana, have a helm-chart repository, contains many versions of charts. usage document.

image image

@daviderli614
Copy link
Contributor Author

The bytebase helm chart version is always 1.1.0.

We have other versions before, likes 1.0.0, but we deletes these versions because we deprecated some Bytebase images.

When new features are added in the chart, it is still this version.

Oops, it seems like we forget to bump the Helm version while we add support for resource control via #11094.

Suggestion to add appVersion in the chart.yaml

We will look into this, thanks!

appVersion is usually the bytebase docker image version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants