Move call to tagIsInvalid to FormHelper

tagIsInvalid() doesn't exist in Helper, and shouldn't be called from that class. Fixes #2411
cakephp · Dec 24, 2011 · 2c0e030 · 2c0e030
1 parent ca14583
commit 2c0e030
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/Cake/View/Helper.php b/lib/Cake/View/Helper.php
@@ -672,9 +672,6 @@ protected function _initInputField($field, $options = array()) {
 		$options = $this->_name($options);
 		$options = $this->value($options);
 		$options = $this->domId($options);
-		if ($this->tagIsInvalid() !== false) {
-			$options = $this->addClass($options, 'form-error');
-		}
 		return $options;
 	}
 

diff --git a/lib/Cake/View/Helper/FormHelper.php b/lib/Cake/View/Helper/FormHelper.php
@@ -2495,6 +2495,9 @@ protected function _initInputField($field, $options = array()) {
 		}
 
 		$result = parent::_initInputField($field, $options);
+		if ($this->tagIsInvalid() !== false) {
+			$result = $this->addClass($result, 'form-error');
+		}
 		if ($secure === self::SECURE_SKIP) {
 			return $result;
 		}