Rename method to better reflect what it does.

cakephp · May 13, 2017 · 3d96541 · 3d96541
1 parent 4ce5591
commit 3d96541
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/Routing/Middleware/RoutingMiddleware.php b/src/Routing/Middleware/RoutingMiddleware.php
@@ -58,7 +58,7 @@ public function __construct(BaseApplication $app = null)
     protected function loadRoutes()
     {
         if ($this->app) {
-            $builder = Router::getRouteBuilder('/');
+            $builder = Router::createRouteBuilder('/');
             $this->app->routes($builder);
             // Prevent routes from being loaded again
             Router::$initialized = true;

diff --git a/src/Routing/Router.php b/src/Routing/Router.php
@@ -917,7 +917,7 @@ public static function parseNamedParams(ServerRequest $request, array $options =
      * @param array $options The options for the builder
      * @return \Cake\Routing\RouteBuilder
      */
-    public static function getRouteBuilder($path, array $options = [])
+    public static function createRouteBuilder($path, array $options = [])
     {
         $defaults = [
             'routeClass' => static::defaultRouteClass(),
@@ -980,7 +980,7 @@ public static function scope($path, $params = [], $callback = null)
             $options = $params;
             unset($params['routeClass'], $params['extensions']);
         }
-        $builder = static::getRouteBuilder('/', $options);
+        $builder = static::createRouteBuilder('/', $options);
         $builder->scope($path, $params, $callback);
     }
 

diff --git a/tests/TestCase/Routing/RouterTest.php b/tests/TestCase/Routing/RouterTest.php
@@ -3358,13 +3358,13 @@ public function testGetRouteCollection()
      *
      * @return void
      */
-    public function testGetRouteBuilder()
+    public function testCreateRouteBuilder()
     {
-        $builder = Router::getRouteBuilder('/api');
+        $builder = Router::createRouteBuilder('/api');
         $this->assertInstanceOf(RouteBuilder::class, $builder);
         $this->assertSame('/api', $builder->path());
 
-        $builder = Router::getRouteBuilder('/', [
+        $builder = Router::createRouteBuilder('/', [
             'routeClass' => 'InflectedRoute',
             'extensions' => ['json']
         ]);