Skip to content

Commit

Permalink
Missing @return
Browse files Browse the repository at this point in the history
FYI: Return type is not inherited with @inheritdoc is used.
  • Loading branch information
thinkingmedia committed Aug 25, 2016
1 parent cc1cbdb commit 4c4b02b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/ORM/Query.php
Expand Up @@ -180,6 +180,7 @@ public function __construct($connection, $table)
* @param array|\Cake\Database\ExpressionInterface|string|\Cake\ORM\Table|\Cake\ORM\Association $fields fields
* to be added to the list.
* @param bool $overwrite whether to reset fields with passed list or not
* @return $this
*/
public function select($fields = [], $overwrite = false)
{
Expand Down

3 comments on commit 4c4b02b

@dereuromark
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ .. inside commit messages is never a good idea ;)
At least not without space between.
Now its always linking to those profiles.

@markstory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think @inheritdoc will mind. It looks like a ghost account.

@dereuromark
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @return does? :D

Please sign in to comment.