Skip to content

Commit

Permalink
Remove invalid code.
Browse files Browse the repository at this point in the history
Fixes #4002
  • Loading branch information
markstory committed Aug 20, 2013
1 parent b711d38 commit 6785589
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/Cake/Console/Command/ConsoleShell.php
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,6 @@ protected function _columns($command) {
protected function _routesReload() {
if (!$this->_loadRoutes()) {
$this->err(__d('cake_console', "There was an error loading the routes config. Please check that the file exists and is free of parse errors."));
break;
}
$this->out(__d('cake_console', "Routes configuration reloaded, %d routes connected", count(Router::$routes)));
}
Expand Down

2 comments on commit 6785589

@dereuromark
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldnt that be return $this->error() then instead? The second message then just says "ok" again, kind of the opposite. And the code continues.

@markstory
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it should. I'll fix that.

Please sign in to comment.