Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module fstab should not add keyfile/password options in crypttab when luksbootkeyfile module is disabled #2310

Closed
eugenesan opened this issue Apr 10, 2024 · 1 comment · Fixed by #2314

Comments

@eugenesan
Copy link
Contributor

eugenesan commented Apr 10, 2024

I am working on Kubuntu installer with systemd-boot, encrypted root, no boot partition.
So far I managed to get it working by altering only config files but there is one issue that requires code change.

When I remove luksbootkeyfile, fstab still adds keyfile/password option to crypttab, making target unbootable without manual edit of crypttab.

I guess the following logic

if any([p["mountPoint"] == "/"

should check when luksbootkeyfile is disabled or/and when bootloader doesn't require access to /boot as it is with systemd-boot which boots linux/initrd from EFI.

Tested on Ubuntu 24.04, Calamares 3.3.5

@dalto8
Copy link
Contributor

dalto8 commented Apr 11, 2024

I think we should fix line:

password = "/crypto_keyfile.bin"

It should be "none" by default and only get set to the keyfile path if the keyfile exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants