Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialSwapChoice: file creates a swapfile in manual partitioning without warning #2320

Open
wxl opened this issue Apr 17, 2024 · 0 comments

Comments

@wxl
Copy link
Contributor

wxl commented Apr 17, 2024

Describe the bug
When doing Manual Partitioning, there is no option to choose whether or not to create a swapfile as there is with the Erase Disk option. Instead, one would need to create it outside of the installer. However, when initialSwapChoice: file is set, a swapfile is created nonetheless without any indication to the user.

To Reproduce

  1. Select Manual Partitioning
  2. Create any partition scheme, with or without a swap partition
  3. Note there is no indication of a swapfile being created, nor any UI element to allow for it
  4. Continue to the Summary panel
  5. Note that there is no indication of a swapfile being created
  6. Complete the installation
  7. Note the swapfile in /etc/fstab

Expected behavior

  1. No swapfile is created
    OR
  2. There is an indication that a swapfile will be created by default, but the user is given a choice otherwise

Additional context

Possible solutions

  1. Show the creation of swapfiles in the Summary panel
    • So at least users aren't surprised… as much
    • To me, this seems to be essential, as otherwise the Summary is not portraying the whole picture
    • Additionally, what if you accidentally picked the wrong filesystem for your swapfile? Wouldn't you want some indication before you go through the actual install?
  2. Assume initialSwapChoice: none when doing Manual Partitioning
    • This also seems essential to me because if we do otherwise, we are forcing choices down the throats of folks we believe (should) know what they're doing
  3. Provide an option in Manual Partitioning to choose swapfile options
    • This seems like a nice option to add
    • If the folks doing Erase Disk have the option, shouldn't the Manual Partitioning folks have it, too?
    • One might argue that the Manual Partitioning folks know what they're doing and would just set it up themselves before/after, but one could also make that argument about partitioning in general
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant