Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability Improvement: Avoid Rebooting into Installation Medium and Allow Configurable Finish Module Text in Calamares #2321

Open
adrelanos opened this issue Apr 18, 2024 · 4 comments

Comments

@adrelanos
Copy link

Is your feature request related to a problem? Please describe.

At the conclusion of the installation using the Calamares installer, the finish module prompts users to reboot the system. A potential issue arises when users reboot with the installation medium, like a DVD or USB ISO image, still connected. This often results in the system booting from the installation medium again rather than the installed system. While Debian's older d-i installer used an eject command to prompt the removal of DVDs, there is no equivalent method for USB devices, leading to potential confusion.

Describe the solution you'd like

I propose the following enhancements to the Calamares finish module:

  1. Introduce configurable text to better guide users during the final installation steps.
  2. Provide an option to shut down (power off) the system instead of rebooting, allowing users to manually remove the USB device before powering on again.

This approach aims to clearly inform users about the need to remove the installation medium before restarting their system.

Describe alternatives you've considered

Alternatives include:

  1. Modifying the Calamares finish module to issue a poweroff command instead of a reboot.
  2. Developing a custom Calamares module that provides textual information, running it just before the finish module.
  3. Improving the hardcoded text within the existing Calamares finish module to offer a clearer explanation of the steps users should take after installation.
@ezsit55
Copy link

ezsit55 commented Apr 18, 2024

This can already be controlled by the finished.conf, at least controlling the buttons and their actions. As per the text, why is this really necessary?

@demmm
Copy link
Contributor

demmm commented Apr 19, 2024

The finishedq module gives you all the options to create custom text/layout/buttons ((create your own QML file).

@adrelanos
Copy link
Author

This can already be controlled by the finished.conf, at least controlling the buttons and their actions.

Not good to change restartNowCommand: "systemctl -i reboot" to restartNowCommand: "systemctl -i poweroff" if the text is still the same.

As per the text, why is this really necessary?

Necessary to explain the issue which I describe in my original post.

The finishedq module gives you all the options to create custom text/layout/buttons ((create your own QML file).

The following code seems hardcoded.

https://github.com/calamares/calamares/blob/calamares/src/modules/finished/FinishedPage.cpp

            ui->mainText->setText( tr( "<h1>All done.</h1><br/>"
                                       "%1 has been installed on your computer.<br/>"
                                       "You may now restart into your new system, or continue "
                                       "using the %2 Live environment.",
                                       "@info" )
                                       .arg( branding->versionedName(), branding->productName() ) );

Message "You may now restart into your new system, or continue " seems hardcoded.

There is no QML file in this folder:
https://github.com/calamares/calamares/tree/calamares/src/modules/finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants