Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User command flow control is handled in the log stream #18120

Closed
Tracked by #17547
oleschoenburg opened this issue Apr 30, 2024 · 0 comments · Fixed by #18368
Closed
Tracked by #17547

User command flow control is handled in the log stream #18120

oleschoenburg opened this issue Apr 30, 2024 · 0 comments · Fixed by #18368
Assignees
@oleschoenburg
Labels
component/zeebe Related to the Zeebe component/team kind/task Categorizes an issue as a breakdown of low-level implementation detail from a parent issue

Comments

@oleschoenburg
Copy link
Member

oleschoenburg commented Apr 30, 2024 •
edited

Move the existing backpressure for user commands to the log stream module and have it handled by FlowControl.

We will not change the default configuration and will maintain backwards compatible with the old configuration schema.
@oleschoenburg oleschoenburg mentioned this issue Apr 30, 2024
Open
@oleschoenburg oleschoenburg added kind/task Categorizes an issue as a breakdown of low-level implementation detail from a parent issue component/zeebe Related to the Zeebe component/team labels Apr 30, 2024
@oleschoenburg oleschoenburg self-assigned this Apr 30, 2024
@oleschoenburg oleschoenburg mentioned this issue May 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 8, 2024
@oleschoenburg
refactor: track in-flight entries for flow control (#18297)
262010a 
## Description

Preparation for handling user command flow control here too. Unlike flow
control for appends, we can't pass around a listener and instead have to
keep a map of positions to listeners.

## Related issues

relates to #18120
@oleschoenburg oleschoenburg mentioned this issue May 8, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 22, 2024
@oleschoenburg
Move user command backpressure to log stream module (#18368)
4d797d2 
## Description

User command backpressure used to be implemented in
`CommandApiRequestHandler`. This PR moves it to the log stream module.

Backpressure is still configurable via `zeebe.broker.backpressure` but
`zeebe.broker.flowControl` takes precedence.

## Related issues

closes #18120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleschoenburg oleschoenburg

Labels
component/zeebe Related to the Zeebe component/team kind/task Categorizes an issue as a breakdown of low-level implementation detail from a parent issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move user command backpressure to log stream module camunda/camunda
1 participant
@oleschoenburg