Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and address TODOs #17342

Closed
Tracked by #17338
nicpuppa opened this issue Apr 5, 2024 · 0 comments · Fixed by #18425
Closed
Tracked by #17338

Review and address TODOs #17342

nicpuppa opened this issue Apr 5, 2024 · 0 comments · Fixed by #18425
Assignees
@nicpuppa
Labels
component/clients component/zeebe Related to the Zeebe component/team kind/feature Categorizes an issue or PR as a feature, i.e. new behavior scope/clients-spring Spring Zeebe Client

Comments

@nicpuppa
Copy link
Contributor

nicpuppa commented Apr 5, 2024 •
edited

Review and address all the TODOs into the project, refactor the code where needed and improve maintainability

Blocked by #17340
@nicpuppa nicpuppa mentioned this issue Apr 5, 2024
Open
@nicpuppa nicpuppa added kind/feature Categorizes an issue or PR as a feature, i.e. new behavior component/clients component/zeebe Related to the Zeebe component/team scope/clients-spring Spring Zeebe Client labels Apr 5, 2024
@nicpuppa nicpuppa mentioned this issue Apr 25, 2024
Merged
@nicpuppa nicpuppa self-assigned this May 2, 2024
@nicpuppa nicpuppa mentioned this issue May 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 14, 2024
@nicpuppa
refactor: address and resolve TODOs (#18425)
cf2186e 
## Description

- made job maxRetries configurable via @Jobworker annotation
- moved metrics to command callback
- changed the way how the SDK handle error code, throwing an error every
also when an endpoint is not found
- removed old todos

## Related issues

closes #17342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicpuppa nicpuppa

Labels
component/clients component/zeebe Related to the Zeebe component/team kind/feature Categorizes an issue or PR as a feature, i.e. new behavior scope/clients-spring Spring Zeebe Client
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: address and resolve TODOs camunda/camunda
1 participant
@nicpuppa