Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled button is transparent on a floating background #4903

Open
Jay-Topher opened this issue Nov 3, 2023 · 3 comments
Open

Disabled button is transparent on a floating background #4903

Jay-Topher opened this issue Nov 3, 2023 · 3 comments
Labels
Blocked ⛔ WG: Proposal Working group proposals

Comments

@Jay-Topher
Copy link

Describe the bug

Currently, the color used to represent a disabled button in vanilla is a lighter (more transparent) hue of the original button color, this works well for the most part, but is problematic when the button is made to float over a dynamic background (e.g: a map)

To Reproduce

Steps to reproduce the behavior:

  1. Create a button that floats on a dynamic (multi-colored) background
  2. Make the button disabled

Expected behavior

The button should be opaque to improve readability

Screenshots

map-shot

@arize99
Copy link

arize99 commented Nov 3, 2023

Hi. Nice contribution. You can also play with the opacity:
<button style={{ opacity: 0.5 }}>Button</button>
😉🤷🏽‍♂️

@bartaz bartaz added the WG: Proposal Working group proposals label Nov 9, 2023
@danielmutis
Copy link

danielmutis commented Nov 15, 2023

Ideally, this would be fixed by flattening the transparency and providing shades of colour for each state. We don't have the time to work on this right now, so for now we suggest using a wrapper on the component that provides a background to make it solid.

@danielmutis
Copy link

For further discussion: what sort of components are we allowed to use on non-flat backgrounds? Is it okay to use other components, like radio buttons, on other backgrounds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked ⛔ WG: Proposal Working group proposals
Projects
None yet
Development

No branches or pull requests

4 participants