Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top navigation using grid row #4947

Closed
bartaz opened this issue Jan 17, 2024 · 1 comment
Closed

Top navigation using grid row #4947

bartaz opened this issue Jan 17, 2024 · 1 comment
Labels
Feature 🎁 New feature or request WG: Proposal Working group proposals

Comments

@bartaz
Copy link
Contributor

bartaz commented Jan 17, 2024

Component/pattern to amend

Top navigation

Context

In new designs the top navigation is being recreated using regular grid with col-3 for logo part, and col-9 for items, to keep the 25/75 split similar to the rest of the page. If applied currently this requires some changes to HTML structure and utilities like u-no-padding--left on logo, etc, to be properly aligned.

This results with projects not being consistent between each other, applying some custom styling to accomodate, etc.

We need to officially build this in Vanilla, provide examples, that would allow using this way of building top nav without local hacks.

Examples:

https://microk8s.io/ (with u-no-padding--left and inline style of "margin: -0.75rem")
Juju docs update: canonical/juju.is#510

@bartaz bartaz added WG: Proposal Working group proposals Feature 🎁 New feature or request and removed WG: Proposal Working group proposals labels Jan 17, 2024
@danielmutis
Copy link

@lyubomir-popov to provide definition of how this should work with the grid in order to make it official in Vanilla.

@bartaz bartaz closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature 🎁 New feature or request WG: Proposal Working group proposals
Projects
None yet
Development

No branches or pull requests

2 participants