Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dark theme hrs consistent with light theme #5060

Closed
lyubomir-popov opened this issue Apr 22, 2024 · 1 comment
Closed

Make dark theme hrs consistent with light theme #5060

lyubomir-popov opened this issue Apr 22, 2024 · 1 comment
Labels
WG: Proposal Working group proposals

Comments

@lyubomir-popov
Copy link
Contributor

There's a difference in opacity between hr and muted hr colours between the themes. Can we please use the following values
$colors--dark-theme--border-default: rgba($colors--dark-theme--text-default, 0.3); $colors--dark-theme--border-low-contrast: rgba($colors--dark-theme--text-default, 0.1) !default;

@bartaz
Copy link
Contributor

bartaz commented Apr 22, 2024

@lyubomir-popov Isn't this what you already fixed in this PR? https://github.com/canonical/vanilla-framework/pull/5056/files

@bartaz bartaz closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WG: Proposal Working group proposals
Projects
None yet
Development

No branches or pull requests

2 participants