Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option for sending SIGINT instead of SIGKILL #10

Open
canthefason opened this issue Nov 6, 2016 · 2 comments
Open

Add an option for sending SIGINT instead of SIGKILL #10

canthefason opened this issue Nov 6, 2016 · 2 comments

Comments

@canthefason
Copy link
Owner

With each file change, we are sending SIGKILL command for killing the running process. The problem is, it would leave some open connections behind. For the programs that require graceful shutdowns, it is better to have an optional SIGINT support for go-watcher.

@julianxhokaxhiu
Copy link

CLI argument for the binary, ENV variable for the Docker ( which will be then passed as CLI argument ), is my proposal. What do you think?

@penkovski
Copy link

@canthefason Do you plan to add this feature or you prefer contribution for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants