-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Syncers for synchable Id-Providers #2623
Comments
@leoncamel sounds good. Can you split the syncers to different issues? One issue for one syncer. Because one syncer itself is a big code change itself |
@hsluoyz Sure, I will submit idP related syncer as new issue. This issue remains as a umbrella issue to discuss general concepts. |
I add split it into #2624, #2625. Currently, we have many Id-Providers, but not all of them are I just did a quick survey about these Id-Providers:
Correct me if I was wrong. |
@leoncamel can you make PR? |
OK. We will try to make PR for this. But, I think it involve big refactor on frontend & syncer interface and some core logic. And we are not sure if this PR will match casdoor's rodmap. We will give try to make first PR to open discussion on this. |
@leoncamel I think this can be implemented by a new syncer. There's no need to build on top of the OAuth provider. They use different APIs and have nothing much shared in common. |
@hsluoyz Yes. But, I not sure how to share parameters between idP and its syncer. For the WeCom case, they may share Any thoughts? |
@leoncamel no need to share. Just store it in syncer object for a second time |
Currently, it seems casdoor only support database syncer.
In the case, we use AzureAD/WeCom as idP. It will also need some syncer for API-like Id-Providers. For example in this case, the admin role can only modify user info, or assign roles, after the specific user logged in.
So, I think, we need some way to solve this issue:
sync()
? For example, AzureAD provide Microsoft Graph API, and MS Graph's Golang SDK. And other Id-Providers may provide similiar APIsAny comments about this feature request?
The text was updated successfully, but these errors were encountered: