Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/bluestore: simplify LRUCache::trim() #10109

Merged
merged 2 commits into from Jul 6, 2016
Merged

os/bluestore: simplify LRUCache::trim() #10109

merged 2 commits into from Jul 6, 2016

Conversation

xiexingguo
Copy link
Member

No description provided.

@xiexingguo xiexingguo force-pushed the xxg-wip-bluestore-2016-07-02 branch 2 times, most recently from b2786e3 to 846750a Compare July 2, 2016 08:50
liewegas
liewegas reviewed Jul 3, 2016
View reviewed changes
src/include/intarith.h
* eg, ROUND_DOWN_TO(0x5600, 0x100) == 0x5600 (0x56*d)
*/
#ifndef ROUND_DOWN_TO
#define ROUND_DOWN_TO(n, d) ((n) & -(d))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ROUND_DOWN_TO_POW2 ?

@liewegas
Copy link
Member

liewegas commented Jul 3, 2016

second and third commits look good!

@xiexingguo xiexingguo force-pushed the xxg-wip-bluestore-2016-07-02 branch 2 times, most recently from ac96768 to 910c98a Compare July 4, 2016 13:43
@xiexingguo
Copy link
Member Author

xiexingguo commented Jul 4, 2016 •
edited

change set:

  • introduce stop to avoid potential dead loop during debug prefill.

@xiexingguo xiexingguo force-pushed the xxg-wip-bluestore-2016-07-02 branch from 910c98a to 7dc0f50 Compare July 4, 2016 13:56
@xiexingguo
os/bluestore: simplify buffer eviction logic of LRUCache
27657d6 
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@xiexingguo
os/bluestore: make sure path_fd is correctly closed during destruction
25db05d 
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@xiexingguo xiexingguo force-pushed the xxg-wip-bluestore-2016-07-02 branch from 7dc0f50 to 25db05d Compare July 5, 2016 02:11
@xiexingguo xiexingguo changed the title os/bluestore: fix debug prefill of fm; simplify LRUCache::trim() os/bluestore: simplify LRUCache::trim() Jul 5, 2016
@xiexingguo
Copy link
Member Author

@liewegas Move the first change into #10128.

@liewegas liewegas merged commit a4250c7 into ceph:master Jul 6, 2016
@xiexingguo xiexingguo deleted the xxg-wip-bluestore-2016-07-02 branch July 6, 2016 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liewegas liewegas

Labels
bluestore bug-fix
Projects
None yet
Milestone
No milestone
2 participants
@xiexingguo @liewegas