mds: move Finisher to unlocked shutdown #10142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves a deadlock reported in i16042 where the thread calling MDSRankDispatcher::shutdown would hold the mds_lock while asynchronous callbacks in the Finisher would attempt to lock mds_lock. For simplicity, I merged the finisher stop with the messenger shutdown as both need the mds_lock dropped. Fixes: http://tracker.ceph.com/issues/16042 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
|
Manually tested in my env, looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves a deadlock reported in i16042 where the thread calling
MDSRankDispatcher::shutdown would hold the mds_lock while asynchronous
callbacks in the Finisher would attempt to lock mds_lock.
For simplicity, I merged the finisher stop with the messenger shutdown as both
need the mds_lock dropped.
Fixes: http://tracker.ceph.com/issues/16042
Signed-off-by: Patrick Donnelly pdonnell@redhat.com