jewel: mon: "mon metadata" fails when only one monitor exists #10654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, writing to the store was only triggered when MMonMetadata was received from peers, so if you had a single mon then you would always get ENOENT from "mon metadata" Fixes: http://tracker.ceph.com/issues/15866 Signed-off-by: John Spray <john.spray@redhat.com> (cherry picked from commit 93ab00c)
to avoid copying of the std::map Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit dd67eaa)
Because 'r' was set inside loop, these would fail to set it (leaving ENOSYS) if no metadata is present. Signed-off-by: John Spray <john.spray@redhat.com> (cherry picked from commit 5fe4fe4) Conflicts: src/mon/Monitor.cc and src/mon/MDSMonitor.cc changes relate to features that are not backported to jewel
Just because one OSD's metadata is missing, don't give up on outputting all the other OSDs' metadata. Signed-off-by: John Spray <john.spray@redhat.com> (cherry picked from commit 2c7dd5f)
ghost
added
|
@jcsp this is the continuation of #9577 (with @Abhishekvrshny permission ;-). Does it look ok ? |
|
Looks fine to me |
ghost
pushed a commit
that referenced
this pull request
Aug 12, 2016
… one monitor exists Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 16, 2016
… one monitor exists Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 17, 2016
… one monitor exists Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 22, 2016
… one monitor exists Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 22, 2016
… one monitor exists Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 23, 2016
… one monitor exists Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
… one monitor exists Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
… one monitor exists Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
… one monitor exists Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
… one monitor exists Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
… one monitor exists Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16081