Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: librbd: the option 'rbd_cache_writethrough_until_flush=true' dosn't work #10797

Merged
22 commits merged into from
Aug 21, 2016

Conversation

Jason Dillaman and others added 22 commits August 19, 2016 22:59
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 3df7213)
Fixes: http://tracker.ceph.com/issues/16708
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 6064f23)
…bject

if you write an empty object, object map is updated firstly

Signed-off-by: xinxin shu <shuxinxin@chinac.com>
(cherry picked from commit a540738)
Fixes: http://tracker.ceph.com/issues/16386
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
(cherry picked from commit dc41731)
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
(cherry picked from commit 9717417)

Conflicts:
	src/rocksdb this was a mistake in the original commit
Signed-off-by: Xiaowei Chen <chen.xiaowei@h3c.com>
(cherry picked from commit 1a22769)
Signed-off-by: Xiaowei Chen <chen.xiaowei@h3c.com>
(cherry picked from commit 01282eb)
Signed-off-by: Xiaowei Chen <chen.xiaowei@h3c.com>
(cherry picked from commit 461958e)
Signed-off-by: Xiaowei Chen <chen.xiaowei@h3c.com>
(cherry picked from commit aee1559)
Signed-off-by: Xiaowei Chen <chen.xiaowei@h3c.com>
(cherry picked from commit 59397e2)
Signed-off-by: Xiaowei Chen <chen.xiaowei@h3c.com>
(cherry picked from commit 88afa40)
Signed-off-by: Xiaowei Chen <chen.xiaowei@h3c.com>
(cherry picked from commit 2185a62)
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit f7eeacd)
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit f453554)
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 405142c)
Better follows the Ceph C++ style guide

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit f1e3919)
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit a945c2c)
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 65b336f)
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 840a473)
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 2e5076e)
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 4a256f5)

Conflicts:
	src/test/librbd/CMakeLists.txt (test_ConsistencyGroups.cc)
Fixes: http://tracker.ceph.com/issues/16654
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 2d9840a)
@trociny trociny added this to the jewel milestone Aug 19, 2016
@trociny
Copy link
Contributor Author

trociny commented Aug 19, 2016

I ended up with the following chain of cherry-picks to resolve conflicts:

# 5498123 Merge pull request #10762 from dillaman/wip-16654
# Backport ticket: http://tracker.ceph.com/issues/17080
2d9840a librbd: cache was not switching to writeback after first flush

# 57b69b9 Merge pull request #10462 from dillaman/wip-16478
# Backport ticket: http://tracker.ceph.com/issues/16903
4a256f5 test: unit test cases for disabling librbd journal by policy
2e5076e librbd: utilize factory methods to create AioObjectRequest objects
840a473 librbd: convert AioObjectRequest/AioObjectRead classes to templates
65b336f librbd: move read callback helpers to narrowest scope
a945c2c librbd: convert AioImageRequest derived classes to templates
f1e3919 librbd: removed namespace indentation from legacy classes
405142c librbd: do not record journal events if append is disabled by policy
f453554 librbd: remove unused journal replay canceled callback
f7eeacd librbd: optionally support disabling journal appends via policy

# 2066ad8 Merge pull request #9539 from cxwshawn/wip-tc9-fix
# No tracker ticket, still look like no hurt to backport
2185a62 librbd: optimize header file dependency & modify related file.
88afa40 librbd: optimize operation header file dependency
59397e2 librbd: optimize journal header file dependency
aee1559 librbd: optimize image_watcher header file dependency
461958e librbd: optimize image header file dependency
01282eb librbd: optimize exclusive_lock  header file dependency
1a22769 librbd: optimize object-map header file dependency

# 1fe0566 Merge pull request #10060 from trociny/wip-16386
# Backport ticket: http://tracker.ceph.com/issues/16869
9717417 test: fix librbd tests for rbd_skip_partial_discard (Conflicts: src/rocksdb)
dc41731 librbd: discard hangs when 'rbd_skip_partial_discard' is enabled

# 89e5d1c Merge pull request #9535 from xinxinsh/wip-bug
# No tracker ticket, still looks good to backport, anyway
a540738 librbd: object_may_exist always return true when you write an empty object

## 1d4384c Merge pull request #10332 from dillaman/wip-16689
## Backport ticket: http://tracker.ceph.com/issues/16867 -- already merged!
#e5b4188 librbd: optimize away unnecessary object map updates
#b7a4db2 rbd-replay: decode and replay discard IO operations

# 77ec14a Merge pull request #10432 from dillaman/wip-16708
# Original ticket: http://tracker.ceph.com/issues/16708
# pending backport (no backport ticket yet)
6064f23 librbd: ensure that AIO ops are started prior to request
3df7213 librbd: helper method for creating and starting AioCompletions

@ghost ghost self-assigned this Aug 19, 2016
@trociny
Copy link
Contributor Author

trociny commented Aug 21, 2016

I tested this locally -- no issues detected. Also, was running this on teuthology:

teuthology-suite --suite rbd --ceph wip-mgolub-testing --owner mgolub --email mgolub@mirantis.com --machine-type vps --suite-branch jewel --filter-out qemu

The results are here:
http://pulpito.ceph.com/trociny-2016-08-20_15:51:06-rbd-wip-mgolub-testing---basic-vps/
There were 7 dead jobs, which are looks like some environment issue, and 10 failed jobs.

Most of failed jobs are due to valgrind errors, which is a known issue, one rbd_mirror_stress.sh failure (currently it is known to may fail), one was TestJournalReplay.Rename failure:

http://qa-proxy.ceph.com/teuthology/trociny-2016-08-20_15:51:06-rbd-wip-mgolub-testing---basic-vps/376109/teuthology.log

This last one was believed to be fixed, but it looks like it is still observable:

http://tracker.ceph.com/issues/16019

Summarizing, the test results look ok to me.

@ghost ghost merged commit cdd4ab2 into ceph:jewel Aug 21, 2016
@ghost ghost changed the title jewel: the option 'rbd_cache_writethrough_until_flush=true' dosn't work jewel: librbd: the option 'rbd_cache_writethrough_until_flush=true' dosn't work Aug 25, 2016
@knandya
Copy link

knandya commented Aug 30, 2016

@dachary : Is this PR going to be part of 10.2.3 release?

@ghost
Copy link

ghost commented Aug 30, 2016

@knandya yes !

@knandya
Copy link

knandya commented Aug 30, 2016

@dachary : Thanks!. Same with #10565 too?

@ghost
Copy link

ghost commented Aug 30, 2016

@knandya you can find a complete list of the issues fixed in 10.2.3 at http://tracker.ceph.com/versions/518

@trociny trociny deleted the wip-17080-jewel branch September 9, 2016 12:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants