Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jewel: rgw: remove spurious mount entries for RGW buckets #12045

Merged
merged 1 commit into from Jan 31, 2017
Merged

jewel: rgw: remove spurious mount entries for RGW buckets #12045

merged 1 commit into from Jan 31, 2017

Conversation

Abhishekvrshny
Copy link

@mattbenjamin
rgw_file: fix spurious mount entries w/Linux NFS client
b044361 
This change fixes the initialization of root file handles to have
their correct fs instance.  Previously, the root file handle had
fs_inst-1.  The apparent change in fsid in a subordinate directory
triggers the client's behavior for new filesystem mounts, which
we don't want.

Fixes: http://tracker.ceph.com/issues/17850

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit d929ba0)
@Abhishekvrshny Abhishekvrshny changed the base branch from jewel to jewel-next November 17, 2016 14:41
@Abhishekvrshny Abhishekvrshny added this to the jewel milestone Nov 17, 2016
@Abhishekvrshny Abhishekvrshny self-assigned this Nov 17, 2016
ghost pushed a commit that referenced this pull request Nov 23, 2016
Merge pull request #12045: jewel: rgw file: remove spurious mount ent…
ab57d4c 
…ries for RGW buckets

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Dec 5, 2016
Merge pull request #12045: jewel: rgw file: remove spurious mount ent…
2987324 
…ries for RGW buckets

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost changed the title jewel: rgw file: remove spurious mount entries for RGW buckets jewel: rgw: file: remove spurious mount entries for RGW buckets Dec 5, 2016
@ghost ghost changed the base branch from jewel-next to jewel December 21, 2016 23:29
@smithfarm
Copy link
Contributor

Jenkins re-test this please

@cbodley cbodley mentioned this pull request Jan 31, 2017
Closed
@mattbenjamin mattbenjamin merged commit d1a019a into ceph:jewel Jan 31, 2017
@smithfarm
Copy link
Contributor

@mattbenjamin JFYI, this PR was still going through integration testing and would have been merged in due course.

@smithfarm
Copy link
Contributor

This passed rgw runs at http://tracker.ceph.com/issues/17851#note-50 and http://tracker.ceph.com/issues/17851#note-58

@smithfarm smithfarm changed the title jewel: rgw: file: remove spurious mount entries for RGW buckets jewel: rgw: remove spurious mount entries for RGW buckets Feb 1, 2017
@smithfarm
Copy link
Contributor 

(11:46:45 AM) smithfarm: owasserm: thanks. For jewel integration rgw, then, what it comes down to is verifying that these 6 valgrind failures are all libtcmalloc-related: http://pulpito.front.sepia.ceph.com/smithfarm-2017-01-31_12:35:14-rgw-wip-jewel-backports-distro-basic-smithi/
(11:46:58 AM) smithfarm: owasserm: I will do that now
(11:47:05 AM) owasserm: smithfarm, thanks
(11:47:33 AM) smithfarm: owasserm: and assuming they are tcmalloc related, you said I can directly merge all the rgw PRs? Or do you want me to ask you for review in the PRs first?
(11:47:53 AM) owasserm: smithfarm, yes you can merge them
(11:48:19 AM) smithfarm: ok, will merge and do at least one or two more rgw runs before passing 10.2.6 to QE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Abhishekvrshny Abhishekvrshny

Labels
bug-fix rgw
Projects
None yet
Milestone
jewel
3 participants
@Abhishekvrshny @smithfarm @mattbenjamin