Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jewel: rgw-admin: missing command to modify placement targets #12428

Merged
merged 6 commits into from Feb 1, 2017
Merged

jewel: rgw-admin: missing command to modify placement targets #12428

merged 6 commits into from Feb 1, 2017

Conversation

smithfarm
Copy link
Contributor

@yehudasa @smithfarm
rgw: use set for zonegroup placement target tags
bb9678b 
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
(cherry picked from commit 12162d6)
@yehudasa @smithfarm
rgw-admin: add commands to manage zonegroup placement fields
155641f 
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
(cherry picked from commit a91c7b5)

Conflicts:
	src/rgw/rgw_admin.cc (chose raw_storage_ops_list from master)
@yehudasa @smithfarm
rgw_admin: commands to manage placement targets
4f7147c 
Fixes: http://tracker.ceph.com/issues/18078

added the following commands:

 radosgw-admin zone placement add
 radosgw-admin zone placement modify
 radosgw-admin zone placement rm
 radosgw-admin zone placement list

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
(cherry picked from commit ead132a)

Conflicts:
	src/rgw/rgw_admin.cc (jewel-next lacks the --tier* and --sync-from* options)
	src/test/cli/radosgw-admin/help.t (jewel-next lacks the --tier* and --sync-from* options)
@smithfarm smithfarm self-assigned this Dec 9, 2016
@smithfarm smithfarm added this to the jewel milestone Dec 9, 2016
@cbodley @smithfarm
radosgw-admin: fix 'placment' typos
dbc1b61 
Fixes: http://tracker.ceph.com/issues/18078

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 0cf0898)
@cbodley @smithfarm
radosgw-admin: add 'zonegroup placement default' command
7cfc346 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 711cc13)
@cbodley @smithfarm
radosgw-admin: 'zone placement modify' doesnt require pool names
ddb5403 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit b59afea)

Conflicts:
	src/rgw/rgw_admin.cc (jewel-next lacks --tier* options)
@smithfarm
Copy link
Contributor Author

jenkins test this please

@ghost ghost changed the base branch from jewel-next to jewel-10-2-4 December 21, 2016 23:22
@ghost ghost changed the base branch from jewel-10-2-4 to jewel December 21, 2016 23:22
@smithfarm smithfarm merged commit 2d5f8fd into ceph:jewel Feb 1, 2017
@smithfarm smithfarm deleted the wip-18216-jewel branch February 1, 2017 21:38
@smithfarm
Copy link
Contributor Author

This passed RGW runs at http://tracker.ceph.com/issues/17851#note-50 and http://tracker.ceph.com/issues/17851#note-58

@smithfarm
Copy link
Contributor Author 

(11:46:45 AM) smithfarm: owasserm: thanks. For jewel integration rgw, then, what it comes down to is verifying that these 6 valgrind failures are all libtcmalloc-related: http://pulpito.front.sepia.ceph.com/smithfarm-2017-01-31_12:35:14-rgw-wip-jewel-backports-distro-basic-smithi/
(11:46:58 AM) smithfarm: owasserm: I will do that now
(11:47:05 AM) owasserm: smithfarm, thanks
(11:47:33 AM) smithfarm: owasserm: and assuming they are tcmalloc related, you said I can directly merge all the rgw PRs? Or do you want me to ask you for review in the PRs first?
(11:47:53 AM) owasserm: smithfarm, yes you can merge them
(11:48:19 AM) smithfarm: ok, will merge and do at least one or two more rgw runs before passing 10.2.6 to QE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smithfarm smithfarm

Labels
bug-fix rgw
Projects
None yet
Milestone
jewel
3 participants
@smithfarm @yehudasa @cbodley