libcephfs: cleanups #12830
Merged
libcephfs: cleanups #12830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
|
retest this please |
1 similar comment
|
retest this please |
jcsp
suggested changes
Jan 10, 2017
| @@ -999,7 +999,13 @@ TEST(LibCephFS, BadFileDesc) { | |||
|
|
|||
| ASSERT_EQ(ceph_get_file_stripe_unit(cmount, -1), -EBADF); | |||
| ASSERT_EQ(ceph_get_file_pool(cmount, -1), -EBADF); | |||
| char poolname[80]; | |||
| ASSERT_EQ(ceph_get_file_pool_name(cmount, -1, poolname, sizeof(poolname)); | |||
There was a problem hiding this comment.
missing second argument to ASSERT_EQ, does not compile
There was a problem hiding this comment.
thanks，I fix it
renhwztetecs
force-pushed
the
renhw-wip-libcephfs-misc
branch
from
860cecd
to
4317f36
Compare
Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
renhwztetecs
force-pushed
the
renhw-wip-libcephfs-misc
branch
from
4317f36
to
8fca057
Compare
Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
renhwztetecs
force-pushed
the
renhw-wip-libcephfs-misc
branch
from
8fca057
to
9d185a0
Compare
jcsp
approved these changes
Jan 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.