common/TrackedOp: make TrackedOp::reset_desc() safe #13702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for a reset_desc() call to clear the desc char* while get_desc() is executing such that it will return a nullptr to the caller. This can lead to bad results, like a crash in std::string() (which does not like to take null). Fix this by not clearing desc. Instead, set a separate flag to indicate that desc should be (safely) rebuilt on the next get_desc() call. Fixes: http://tracker.ceph.com/issues/19110 Signed-off-by: Sage Weil <sage@redhat.com>
jdurgin
approved these changes
Feb 28, 2017
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for a reset_desc() call to clear the desc char* while
get_desc() is executing such that it will return a nullptr to the caller.
This can lead to bad results, like a crash in std::string() (which does
not like to take null).
Fix this by not clearing desc. Instead, set a separate flag to indicate
that desc should be (safely) rebuilt on the next get_desc() call.
Fixes: http://tracker.ceph.com/issues/19110
Signed-off-by: Sage Weil sage@redhat.com