osd: crash creating/deleting pools #5527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because new_pools was processed after old_pools, if something was modified and then deleted in the same incremental map, then the resulting state would be a pool in the map that had no entry in pool_name. Fixes: ceph#12429 Signed-off-by: John Spray <john.spray@redhat.com> (cherry picked from commit 8d4932e)
|
@tchaikov does this backport look good to merge ? It passed a run of the hammer rados suite ( see http://tracker.ceph.com/issues/12701#rados for details ). |
ghost
pushed a commit
that referenced
this pull request
Aug 30, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 30, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 30, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 31, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Sep 1, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@dachary lgtm |
ghost
pushed a commit
that referenced
this pull request
Sep 2, 2015
OSD crash creating/deleting pools Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Sep 2, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
changed the title
steveftaylor
pushed a commit
to steveftaylor/ceph
that referenced
this pull request
May 4, 2016
Covers 100% of the LOC and all the expected behavior, including thread safety. The sharedptr_registry is made friend of the test class so that it can synthetize race conditions. The lookup and lookup_or_create methods set the new in_method data member before calling cond.Wait() so that the caller knows it is waiting. http://tracker.ceph.com/issues/5527 refs ceph#5527 Signed-off-by: Loic Dachary <loic@dachary.org> (cherry picked from commit 6b16cd1)
steveftaylor
pushed a commit
to steveftaylor/ceph
that referenced
this pull request
May 4, 2016
A single counter ( waiting ) accurately reflects the number of
waiters, regardless of the method waiting. It is enough to allow
unit tests to synthetise all situations, including:
T1: x = lookup_or_create(0)
T1: release x part 1 (weak_ptrs now fail to lock)
T2: y = lookup_or_create(0)
T2: block in lookup_or_create (waiting == 1)
T1: z = lookup_or_create(1) (does not block because the key is different)
while holding the lock it waiting++ and waiting == 2
and before returning it waiting-- and waiting is back to == 1
T1: complete release x
T2: complete lookup_or_create(0) (waiting == 0)
The unit tests are modified to add a lookup on an unrelated key to
demonstrate that it does not reset waiting counter.
http://tracker.ceph.com/issues/5527 refs ceph#5527
Signed-off-by: Loic Dachary <loic@dachary.org>
(cherry picked from commit 2ec480b)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12585