PerfCounter: Add osd op thread latency counter #5793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
yuyuyu101
force-pushed
the
impl-perf
branch
2 times, most recently
from
c8d2aec
to
de0689a
Compare
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
We don't need l_os_queue_lat to only count the latency of op throttle, this could be done by Throttle counter itself. We may concern the latency consumed by FileJournal submit time. Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
liewegas
added a commit
that referenced
this pull request
Nov 26, 2015
osd: add osd op queue latency perfcounter Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have "l_osd_op_lat" counting from message receive to reply message, "l_osd_op_process_lat" counting from dequeue message to reply message. These two counter could behavior well to find the osd queue time consuming.
But we also need to make sure the detail time consuming in "l_osd_op_process_lat", like how much time consumed for prepare transaction and queue it, and how much time consumed for getting transaction committed.
This change add time counter for osd thread prepare transaction.
| receiving message | osd queue | prepare transaction | queue_transaction | wait committed |
<-------------------------------------------------------------l_osd_op_lat ---------------------------------------->
------------------------------------------<--------------------------l_osd_op_process_la---------------------->
------------------------------------------<---------l_osd_op_prepare_lat---------------->