OSD: faster log, fixed #6441
Merged
OSD: faster log, fixed #6441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xinxinsh : This has nothing to do with the intended work. It was appended by mistake. I will rebase and repush. |
aclamk
force-pushed
the
wip-faster-log-fixed
branch
from
55f5a3c
to
34cd554
Compare
|
@aclamk please ignore the false negative from the bot. Could you please rebase and repush to run it again ? http://tracker.ceph.com/issues/13592 |
ghost
added
aclamk
force-pushed
the
wip-faster-log-fixed
branch
from
34cd554
to
cc3cdf6
Compare
| // returns current size of content | ||
| size_t PrebufferedStreambuf::size() const | ||
| { | ||
| if(m_overflow.size() == 0) { |
There was a problem hiding this comment.
can you please s/if(/if (/ throughout?
aclamk
force-pushed
the
wip-faster-log-fixed
branch
from
cc3cdf6
to
7159f2c
Compare
Got rid of std::string construction. More unification on syslog,stderr,fd. Signed-off-by: Adam Kupczyk <akupczyk@mirantis.com>
aclamk
force-pushed
the
wip-faster-log-fixed
branch
from
7159f2c
to
5bfe05a
Compare
liewegas
added a commit
that referenced
this pull request
Nov 28, 2015
common: optimize debug logging code Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the reiteration of log speed optimization:
Speed optimizations. Merged 3 writes into 1.
Got rid of std::string construction.
More unification on syslog, stderr, fd.
Signed-off-by: Adam Kupczyk (akupczyk@mirantis.com)