-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSD: faster log, fixed #6441
OSD: faster log, fixed #6441
Conversation
@xinxinsh : This has nothing to do with the intended work. It was appended by mistake. I will rebase and repush. |
55f5a3c
to
34cd554
Compare
@aclamk please ignore the false negative from the bot. Could you please rebase and repush to run it again ? http://tracker.ceph.com/issues/13592 |
34cd554
to
cc3cdf6
Compare
// returns current size of content | ||
size_t PrebufferedStreambuf::size() const | ||
{ | ||
if(m_overflow.size() == 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please s/if(/if (/ throughout?
cc3cdf6
to
7159f2c
Compare
Got rid of std::string construction. More unification on syslog,stderr,fd. Signed-off-by: Adam Kupczyk <akupczyk@mirantis.com>
7159f2c
to
5bfe05a
Compare
common: optimize debug logging code Reviewed-by: Sage Weil <sage@redhat.com>
This is the reiteration of log speed optimization:
Speed optimizations. Merged 3 writes into 1.
Got rid of std::string construction.
More unification on syslog, stderr, fd.
Signed-off-by: Adam Kupczyk (akupczyk@mirantis.com)