Init rbdmap patchset. #6445
Merged
Init rbdmap patchset. #6445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch rewrites the init-rbdmap init script so that it uses logger instead of the log_* functions. The patch also fixes various smaller bugs like: * MAP_RV was undefined if mapping already existed * UMNT_RV and UMAP_RV were almost always empty (if they succeeded) -> removed them * use of continue instead RET_OP in various places (RET_OP was not being checked after the switch to logger messages) * removed use of DESC (used only twice and only one occurrence actually made sense) Signed-off-by: Boris Ranto <branto@redhat.com>
Drop the redhat-lsb-core dependency as it is no longer necessary on fedora/rhel. The other two init scripts do not use redhat-lsb-core either. The init-ceph.in conditionally requires /lib/lsb/init-functions and does not use any of the functions defined in that file (at least not directly). The init-radosgw file includes /etc/rc.d/init.d/functions on non-debian platforms instead of /lib/lsb/init-functions file so it does not require redhat-lsb-core either. Signed-off-by: Boris Ranto <branto@redhat.com>
|
Can we please get this merged? The commits are already in infernalis, only master is missing them and it blocks PR #6443 rbdmap systemd support (the patches directly depend on them). |
|
the pr for infernalis is #6363 |
|
lgtm |
tchaikov
added a commit
that referenced
this pull request
Nov 5, 2015
Init rbdmap patchset. Reviewed-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I aimed this for infernalis initially hoping that it would get "back-ported" to master. However it does not seem that way (the original patches are in infernalis for quite some time). Opening another PR for master.