Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hammer: osd: bug with cache/tiering and snapshot reads #6589

Merged
1 commit merged into from Nov 25, 2015

Conversation

theanalyst
Copy link
Member

reset ssc->exsits in finish_ctx() if the ctx->cache_evict is true, and
the head is removed.

Fixes: ceph#12748
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit b61f3e4)
@theanalyst theanalyst self-assigned this Nov 14, 2015
@theanalyst theanalyst added this to the hammer milestone Nov 14, 2015
@theanalyst
Copy link
Member Author

Since the upstream PR (#6261) needed an additional test case in the qa suite, for the backport PR, it may be necessary to add the specific test to the ceph-qa-suite as well before merging this one.

ghost pushed a commit that referenced this pull request Nov 16, 2015
…merged, needs a test in ceph-qa-suite]

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Nov 19, 2015
…merged, needs a test in ceph-qa-suite]

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Nov 19, 2015
…merged, needs a test in ceph-qa-suite]

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Nov 19, 2015
…merged, needs a test in ceph-qa-suite]

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost changed the title bug with cache/tiering and snapshot reads [merged, needs a test in ceph-qa-suite] bug with cache/tiering and snapshot reads Nov 21, 2015
@ghost
Copy link

ghost commented Nov 21, 2015

It passed a run of the hammer rados suite ( see http://tracker.ceph.com/issues/13356#note-28 for details ).

teuthology-openstack --verbose --key-name myself --key-filename ~/Downloads/myself --verbose --suite rados --ceph-qa-suite-git-url https://github.com/dachary/ceph-qa-suite.git --suite-branch wip-12748-hammer --ceph-git-url https://github.com/ceph/ceph.git --ceph hammer-backports --filter="export-after-evict.yaml" 

Using a backport of the test ceph/ceph-qa-suite#720

@ghost ghost changed the title bug with cache/tiering and snapshot reads osd: bug with cache/tiering and snapshot reads Nov 21, 2015
@ghost
Copy link

ghost commented Nov 21, 2015

@tchaikov it passes a rados suite and a backport of the matching test (see #6589 (comment)). Does it look good to merge ?

@ghost ghost assigned tchaikov and unassigned theanalyst Nov 21, 2015
@tchaikov
Copy link
Contributor

lgtm!

ghost pushed a commit that referenced this pull request Nov 25, 2015
osd: bug with cache/tiering and snapshot reads

Reviewed-by: Kefu Chai <kchai@redhat.com>
@ghost ghost merged commit 9b97e4f into ceph:hammer Nov 25, 2015
@ghost ghost changed the title osd: bug with cache/tiering and snapshot reads hammer: osd: bug with cache/tiering and snapshot reads Feb 18, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants