rgw: add bucket request payment feature usage statistics integration #6656
Conversation
|
@yehudasa usage log example covering different cases available at: http://tracker.ceph.com/attachments/download/2086/bpr-ul-example-001.txt |
|
@yehudasa Not sure if I am understanding rightly. It is expected breaking the compatibility with older entries due to indexation change (by bucket user instead of bucket owner with the new code). Would it make sense some kind of compatibility with the old entries? |
|
@jmunhoz the problem is that it would be incompatible with previously created entries, so people who upgrade will lose their history. |
|
@jmunhoz Does Yehuda's comment make sense? Do you need additional guidance? |
|
@liewegas yes, the Yehuda's comment makes a lot of sense. Right now I am working on the AWS4 auth corner cases and the testing coverage with Yehuda but my idea is coming back here asap. I would have to review the code again but I remember I didn't find any clear way to guarantee this compatibility in a quick look. As seen at http://tracker.ceph.com/attachments/download/2086/bpr-ul-example-001.txt the approach looks quite different from the current one. Any suggestion to connect both approaches? thanks sage! |
jmunhoz
force-pushed
the
wip-bucket-request-payment-usage-log
branch
from
ac31ae6
to
3848926
Compare
|
it's incomplete, but that's the basic idea. (there's also a needed string -> rgw_user transition that we need to do now that is missing). |
|
@yehudasa I got the idea. I have the code compiling now. I will try to fit the missing bits. thanks! |
|
@yehudasa https://github.com/jmunhoz/ceph/commits/wip-rgw-payer-yehuda I did some changes over your initial patch although I am not getting the expected result. Operations with payer are added under the owner statistics. All things are compiling and it looks working ok but the way how we insert the puser and its log_add_op datapath. I suspect encoding/decoding could be the reason. Do you see any strange thing in the new encoding/decoding code? I think the transitions between strings and rgw_user are ok. |
Log under the virtual error bucket '-' when bucket not found Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
If the payer matches the owner it shows the owner only. Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
jmunhoz
force-pushed
the
wip-bucket-request-payment-usage-log
branch
from
3848926
to
602c61b
Compare
…e-log rgw: add bucket request payment feature usage statistics integration Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
Add usage statistics support for the bucket request payment feature.
Fixes: #13834
Signed-off-by: Javier M. Mellid jmunhoz@igalia.com