osd: release related sources when scrub is interrupted #6744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majianpeng
force-pushed
the
scrub-fix
branch
from
53d3029
to
2b8d511
Compare
|
@tchaikov . I review again code. When delete pg, the code path is: ReplicatedPG::on_removal-->on_shutdown. In func ReplicatedPG::on_shutdown, it forget call scrub_clear_state which decrease active scrub number. So only add scrub_clear_state in on_shutdown can resolve this. |
|
lgtm. |
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
majianpeng
force-pushed
the
scrub-fix
branch
from
2b8d511
to
d0ffeb8
Compare
liewegas
added a commit
that referenced
this pull request
Dec 23, 2015
osd: release related sources when scrub is interrupted Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now scrub is chunky scrub. For a pg, it maybe need more chunky_scrub.
If interrupt scrub, it should free the related sources.
Signed-off-by: Jianpeng Ma jianpeng.ma@intel.com