Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infernalis: librbd: fix merge-diff for >2GB diff-files #6981

Merged
1 commit merged into from
Feb 11, 2016

Conversation

dillaman
Copy link

@dillaman dillaman added this to the infernalis milestone Dec 18, 2015
@jdurgin
Copy link
Member

jdurgin commented Jan 29, 2016

lgtm

ghost pushed a commit that referenced this pull request Feb 8, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost
Copy link

ghost commented Feb 8, 2016

@dillaman could you please git cherry-pick -x 68125dd so that there is a reference to the original commit ? Thanks :-)

For the record:

It passed a run of the infernalis rbd suite ( see http://tracker.ceph.com/issues/13750#note-18 for details ). Note that all valgrind tests in these suites fail because of an environmental problem ( http://tracker.ceph.com/issues/14664 ).

@ghost ghost changed the title librbd: fix merge-diff for >2GB diff-files DNM: librbd: fix merge-diff for >2GB diff-files Feb 8, 2016
@dillaman
Copy link
Author

dillaman commented Feb 8, 2016

@dachary I can if you think that is a good idea -- but this is essentially a brand new commit since absolutely zero lines would translate from the original.

@ghost
Copy link

ghost commented Feb 8, 2016

@dillaman oh, sorry I missed that it does not translate. A simple comment in the commit message about that would be enough. The idea is to make it as easy as possible for someone looking at the commit later on to trace it back to its origin.

Fixes: ceph#14062
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(derived from commit 68125dd)
@dillaman dillaman changed the title DNM: librbd: fix merge-diff for >2GB diff-files librbd: fix merge-diff for >2GB diff-files Feb 11, 2016
@ghost ghost self-assigned this Feb 11, 2016
ghost pushed a commit that referenced this pull request Feb 11, 2016
librbd: fix merge-diff for >2GB diff-files

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
@ghost ghost merged commit f5e33cd into ceph:infernalis Feb 11, 2016
@dillaman dillaman deleted the wip-14062-infernalis branch February 11, 2016 15:33
@Abhishekvrshny Abhishekvrshny changed the title librbd: fix merge-diff for >2GB diff-files infernalis: librbd: fix merge-diff for >2GB diff-files Feb 18, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants