-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infernalis: librbd: fix merge-diff for >2GB diff-files #6981
Conversation
lgtm |
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@dillaman could you please git cherry-pick -x 68125dd so that there is a reference to the original commit ? Thanks :-) For the record: It passed a run of the infernalis rbd suite ( see http://tracker.ceph.com/issues/13750#note-18 for details ). Note that all valgrind tests in these suites fail because of an environmental problem ( http://tracker.ceph.com/issues/14664 ). |
@dachary I can if you think that is a good idea -- but this is essentially a brand new commit since absolutely zero lines would translate from the original. |
@dillaman oh, sorry I missed that it does not translate. A simple comment in the commit message about that would be enough. The idea is to make it as easy as possible for someone looking at the commit later on to trace it back to its origin. |
Fixes: ceph#14062 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (derived from commit 68125dd)
3e3f6b5
to
389ed34
Compare
librbd: fix merge-diff for >2GB diff-files Reviewed-by: Josh Durgin <jdurgin@redhat.com>
http://tracker.ceph.com/issues/14062