-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
librbd: fix snap_exists API return code overflow #6986
Conversation
21a03e6
to
896160e
Compare
@@ -206,7 +206,9 @@ class CEPH_RBD_API Image | |||
|
|||
/* snapshots */ | |||
int snap_list(std::vector<snap_info_t>& snaps); | |||
/* DEPRECATED; use snap_exists2 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would rather see __attribute__ ((deprecated))
appended to snap_exists
.
896160e
to
5a481fb
Compare
The original one may overflow and thus not be safe. Fixes: ceph#14129 Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@dillaman Fixed as you suggested, please review. Thanks a lot! |
Couple more spots that should be swapped over to
|
@dillaman OK~~~, I'll try to find them out as soon as possible:) |
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
b9fe651
to
6a45bbc
Compare
@dillaman Fixed, please review:) Thank you for your patience. |
librbd: fix snap_exists API return code overflow Reviewed-by: Jason Dillaman <dillaman@redhat.com>
http://tracker.ceph.com/issues/14129