rgw: don't use s->bucket for metadata api path entry #7408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #14549 s->bucket is only initialized at the object store handler (post auth callback). We don't want to initialize it for other cases because it's not a real bucket, and initializing it will require going through the authorization path for this 'bucket'. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
|
I think "going through the authorization path" is nice enough. How about this: |
|
@zaitcev the problem there is that we end up keeping s->bucket_name for something that is not a bucket, so it doesn't really make anything better. Also, it's a fix for only this specific op, not a generic fix. I'd rather have something more generic (e.g., setting some other field on the req_state). I think that for now my fix is good enough. |
oritwas
added a commit
that referenced
this pull request
Feb 15, 2016
rgw: don't use s->bucket for metadata api path entry Reviewed-by: Orit Wasserman <owasserm@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14549
s->bucket is only initialized at the object store handler (post auth
callback). We don't want to initialize it for other cases because
it's not a real bucket, and initializing it will require going through
the authorization path for this 'bucket'.
Signed-off-by: Yehuda Sadeh yehuda@redhat.com