tests: test_pidfile.sh lingering processes #7734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will review/test it tomorrow |
|
we are not able to pass the RUNID down to |
ghost
mentioned this pull request
|
@tchaikov repushed an entirely different approach to the problem. What do you think ? |
|
@dachary i believe this is the last change we need before considering it done. |
For the mon, using ps aux to find the process will only show part of the command line and the $RUNID may be missing. For the OSD, the $RUNID is passed using an environment variable and will not show at all. There is no need to test both ceph-osd and ceph-mon since they both end up in the same code path, pidfile_write. Add a log line that only shows when the --pid-file is empty and grep for it in the simplest possible way. The TEST_pidfile test failed to kill a process because there was no pidfile with its pid. This is fixed by backuping the pidfile before it is modified. http://tracker.ceph.com/issues/14834 Fixes: #14834 Signed-off-by: Loic Dachary <loic@dachary.org>
|
@tchaikov good catch ! I fixed it as suggested, it makes perfect sense. |
|
tested using test passed, and no lingering daemon found. |
tchaikov
added a commit
that referenced
this pull request
Feb 25, 2016
tests: test_pidfile.sh lingering processes Reviewed-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ps aux to find the process will only show part of the command line
and the $RUNID may be missing. Use pgrep instead.
http://tracker.ceph.com/issues/14834 Fixes: #14834
Signed-off-by: Loic Dachary loic@dachary.org