librados: race condition on aio_notify completion handling #7864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait for both the notify_finish callback and the standard RADOS ack callback before completing the associated AioCompletion. Otherwise, there is a potential race condition of reading to/writing from an already destructed object. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
lgtm |
liewegas
added a commit
that referenced
this pull request
Mar 9, 2016
librados: race condition on aio_notify completion handling Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for both the notify_finish callback and the standard RADOS ack
callback before completing the associated AioCompletion. Otherwise,
there is a potential race condition of reading to/writing from an
already destructed object.
Signed-off-by: Jason Dillaman dillaman@redhat.com