rbd-mirror: fix missing increment for iterators #8352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runsisi
force-pushed
the
wip-fix-missing-iter
branch
4 times, most recently
from
b71ee7f
to
dca09c3
Compare
|
This change looks good. @dillaman What do you think? |
| @@ -273,10 +273,14 @@ void Replayer::set_sources(const map<int64_t, set<string> > &images) | |||
| images_it != pool_images.end();) { | |||
| if (stop_image_replayer(images_it->second)) { | |||
| pool_images.erase(images_it++); | |||
There was a problem hiding this comment.
While fixing this, can we also switch this (and below) to something like images_it = pool_images.erase(images_it)?
runsisi
force-pushed
the
wip-fix-missing-iter
branch
3 times, most recently
from
ea4fc58
to
23e4504
Compare
|
@dillaman ok, fixed it, thx~ |
|
LGTM |
Signed-off-by: runsisi <runsisi@hust.edu.cn>
runsisi
force-pushed
the
wip-fix-missing-iter
branch
from
23e4504
to
383d48b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rbd-mirror: fix missing increment of iterators in
Replayer::set_sources.Signed-off-by: runsisi runsisi@hust.edu.cn